Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

half guess count in util::try_minimal_primitive_root #430

Merged
merged 1 commit into from
Mar 15, 2022
Merged

half guess count in util::try_minimal_primitive_root #430

merged 1 commit into from
Mar 15, 2022

Conversation

zirconium-n
Copy link
Contributor

Since we are multiplying generator_sq each guess, we should increment i by 2 instead of 1.

@WeiDaiWD WeiDaiWD merged commit 4c1b90b into microsoft:main Mar 15, 2022
@WeiDaiWD
Copy link
Contributor

It makes perfect sense. Thanks for your contribution!

@WeiDaiWD WeiDaiWD mentioned this pull request Mar 15, 2022
Merged
@WeiDaiWD
Copy link
Contributor

This PR should be made to the contrib branch. I'm going to make the commit myself but leave your GitHub info and PR number in the commit message.

WeiDaiWD pushed a commit that referenced this pull request Mar 17, 2022
PR #430 by zirconium-n: reduced util::try_minimal_primitive_root sear…
9e32655 
…ch iterations by half.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zirconium-n @WeiDaiWD